Skip to content

Comments

[BILL-💵, FF-12] Migrate sidebar item to tailwind#4695

Merged
george-aidonidis merged 3 commits intomasterfrom
ff-12-migrate-sidebaritem-to-tw
Apr 9, 2025
Merged

[BILL-💵, FF-12] Migrate sidebar item to tailwind#4695
george-aidonidis merged 3 commits intomasterfrom
ff-12-migrate-sidebaritem-to-tw

Conversation

@george-aidonidis
Copy link
Contributor

@george-aidonidis george-aidonidis commented Mar 13, 2025

FF-12

Description

Migration of Sidebar item to tailwind

How to test

  • All CI checks should pass
  • Check Sidebar.Item on storybook

Development checks

  • Add changeset according to guidelines (if needed)
  • Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • [n/a] Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • Covered with tests (visual tests included)

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping for reviews
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@george-aidonidis george-aidonidis self-assigned this Mar 13, 2025
@george-aidonidis george-aidonidis requested a review from a team as a code owner March 13, 2025 11:16
@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2025

🦋 Changeset detected

Latest commit: f09a43d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@toptal/picasso-page Patch
@toptal/picasso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@george-aidonidis george-aidonidis force-pushed the ff-12-migrate-sidebaritem-to-tw branch 3 times, most recently from 82cbe30 to 1a102eb Compare March 27, 2025 09:36
@george-aidonidis george-aidonidis force-pushed the ff-12-migrate-sidebaritem-to-tw branch 3 times, most recently from f7741bc to 1c498c7 Compare April 8, 2025 15:03
* Add changeset
* Update snapshots
@george-aidonidis george-aidonidis force-pushed the ff-12-migrate-sidebaritem-to-tw branch from 1c498c7 to 1c2bf36 Compare April 9, 2025 00:27
Copy link
Contributor

@vedrani vedrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is there some guideline should we move more of tw stuff inline or keep it in styles?

@george-aidonidis
Copy link
Contributor Author

Hey @vedrani, I am not aware of any guidelines.

@george-aidonidis george-aidonidis merged commit ea49927 into master Apr 9, 2025
17 checks passed
@george-aidonidis george-aidonidis deleted the ff-12-migrate-sidebaritem-to-tw branch April 9, 2025 11:48
@toptal-build toptal-build mentioned this pull request Apr 9, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants