[BILL-💵, FF-12] Migrate sidebar item to tailwind#4695
Merged
george-aidonidis merged 3 commits intomasterfrom Apr 9, 2025
Merged
[BILL-💵, FF-12] Migrate sidebar item to tailwind#4695george-aidonidis merged 3 commits intomasterfrom
george-aidonidis merged 3 commits intomasterfrom
Conversation
🦋 Changeset detectedLatest commit: f09a43d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
82cbe30 to
1a102eb
Compare
vedrani
reviewed
Apr 2, 2025
vedrani
reviewed
Apr 2, 2025
f7741bc to
1c498c7
Compare
* Add changeset * Update snapshots
1c498c7 to
1c2bf36
Compare
vedrani
approved these changes
Apr 9, 2025
Contributor
vedrani
left a comment
There was a problem hiding this comment.
Looks good. Is there some guideline should we move more of tw stuff inline or keep it in styles?
Contributor
Author
|
Hey @vedrani, I am not aware of any guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FF-12
Description
Migration of Sidebar item to tailwind
How to test
Sidebar.Itemon storybookDevelopment checks
picasso-tailwind-mergerequires major update (check itsREADME.md)propsin component with documentationexamplesfor componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release- Release alpha version@toptal-anvil ping reviewers- Ping for reviewsPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?