Skip to content

[TAPS-0000] Migrate Button and Switch to BASE UI#4906

Open
OleksandrNechai wants to merge 5 commits into
feature/picasso-modernizationfrom
migrate-button-switch-to-base-ui
Open

[TAPS-0000] Migrate Button and Switch to BASE UI#4906
OleksandrNechai wants to merge 5 commits into
feature/picasso-modernizationfrom
migrate-button-switch-to-base-ui

Conversation

@OleksandrNechai
Copy link
Copy Markdown
Collaborator

@OleksandrNechai OleksandrNechai commented Mar 4, 2026

Migrated Button and Switch components from @mui/base to @base-ui/react.

User prompt to Codex:

Component is Switch
Your goal is to migrate Component from @mui/base to @base-ui/react

Directions:
- use Playwright MCP to compare visually
- use storybook baseline: https://picasso.toptal.net/
- Use `yarn start` to start local storybook where you can check your current work at http://localhost:9001/
- find component in storybook sidebar and click on it to get to component

Constraints:
- Test changes are not allowed except updating snapshots
- Minimal code changes
- Only proceed to final acceptance criteria after you achieved working acceptance criteria 

Working acceptance criteria (run for regular feedback):
- Picasso's component does not reference @mui/base anymore as it is deprecated
- yarn test:unit
- visual comparison is pixel perfect for all stories and variants of Component
- visual comparison should also be done in different interaction states: default, hover, clicked, focused

Full acceptance criteria (run before finish):
- working acceptance criteria pass
- tests pass (yarn test)
- `yarn lint`pass
- `yarn typecheck` pass

After Happo failed, follow up:

Pull request: https://github.com/toptal/picasso/pull/4906
Happo repot fails for both Switch and Button
Happo token is on the image
Your job now is to iterate until you commit and happo is report is green
to communicate with GitHub use GH CLI

@OleksandrNechai OleksandrNechai requested a review from a team as a code owner March 4, 2026 19:39
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 4, 2026

⚠️ No Changeset found

Latest commit: 9331194

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OleksandrNechai OleksandrNechai changed the title Migrate Button and Switch to BASE UI [TAPS-0000] Migrate Button and Switch to BASE UI Mar 4, 2026
@OleksandrNechai OleksandrNechai self-assigned this Mar 4, 2026
@toptal toptal deleted a comment from github-actions Bot Mar 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

📖 Storybook Preview

🚀 Your Storybook preview is ready: View Storybook

📍 Preview URL: https://toptal.github.io/picasso/prs/4906/

This preview is updated automatically when you push changes to this PR.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

📖 Storybook Preview

🚀 Your Storybook preview is ready: View Storybook

📍 Preview URL: https://toptal.github.io/picasso/prs/4906/

This preview is updated automatically when you push changes to this PR.

Comment thread packages/base/Button/src/ButtonBase/ButtonBase.tsx Outdated
Comment thread packages/base/Button/src/ButtonBase/ButtonBase.tsx Outdated
@vedrani
Copy link
Copy Markdown
Collaborator

vedrani commented May 5, 2026

🛑 Orchestrator escalation — Button

Trigger: iteration cap (3) hit; last gate=FAIL
Iterations: 3 / 3
PR: #4906
Worktree: (removed)
Last gate report: /Users/vivanac/Projects/picasso/migration-runs/2026-05-05/Button/worktree/migration-runs/2026-05-05/Button/report.md

See docs/migration/references/escalation.md for the full handoff procedure.

@narghev narghev changed the base branch from master to picasso-modernization May 6, 2026 08:19
@vedrani
Copy link
Copy Markdown
Collaborator

vedrani commented May 6, 2026

🛑 Orchestrator escalation — Button

Trigger: iteration cap (3) hit; last gate=FAIL
Iterations: 3 / 3
PR: #4906
Worktree: (removed)
Last gate report: /Users/vivanac/Projects/picasso/migration-runs/2026-05-06/Button/worktree/migration-runs/2026-05-06/Button/report.md

See docs/migration/references/escalation.md for the full handoff procedure.

@vedrani
Copy link
Copy Markdown
Collaborator

vedrani commented May 6, 2026

🛑 Orchestrator escalation — Button

Trigger: git push failed: To github.com:toptal/picasso.git
! [rejected] migrate-Button -> migrate-Button (non-fast-forward)
error: failed to push some refs to 'github.com:toptal/picasso.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. If you want to integrate the remote changes,
hint: use 'git pull' before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

Iterations: 1 / 3
PR: #4906
Worktree: (removed)
Last gate report: /Users/vivanac/Projects/picasso/migration-runs/2026-05-06/Button/worktree/migration-runs/2026-05-06/Button/report.md

See docs/migration/references/escalation.md for the full handoff procedure.

@vedrani vedrani deleted the branch feature/picasso-modernization May 6, 2026 11:35
@vedrani vedrani closed this May 6, 2026
@vedrani vedrani reopened this May 6, 2026
@vedrani vedrani changed the base branch from picasso-modernization to feature/picasso-modernization May 6, 2026 11:36
@vedrani
Copy link
Copy Markdown
Collaborator

vedrani commented May 6, 2026

🛑 Orchestrator escalation — Button

Trigger: gate did not pass after 10 iterations
Iterations: 10 / 3
PR: #4906
Worktree: (removed)
Last gate report: (none)

See docs/migration/references/escalation.md for the full handoff procedure.

@narghev narghev force-pushed the migrate-button-switch-to-base-ui branch from 2a31a58 to e10a9c1 Compare May 6, 2026 14:51
@vedrani
Copy link
Copy Markdown
Collaborator

vedrani commented May 6, 2026

🛑 Orchestrator escalation — Button

Trigger: CI timeout after 15min; pending:
Iterations: 1 / 3
PR: #4906
Worktree: (removed)
Last gate report: /Users/vivanac/Projects/picasso/migration-runs/2026-05-06/Button/worktree/migration-runs/2026-05-06/Button/report.md

See docs/migration/references/escalation.md for the full handoff procedure.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

📖 Storybook Preview

🚀 Your Storybook preview is ready: View Storybook

📍 Preview URL: https://toptal.github.io/picasso/prs/4906/

This preview is updated automatically when you push changes to this PR.

github-actions Bot added a commit that referenced this pull request May 6, 2026
@vedrani
Copy link
Copy Markdown
Collaborator

vedrani commented May 6, 2026

🛑 Orchestrator escalation — Button

Trigger: CI failure on "Happo (Picasso/Cypress)" (Happo (Picasso/Cypress) failed after 1 rerun(s) — likely real regression, not flake)
Iterations: 8 / 3
PR: #4906
Worktree: (removed)
Last gate report: /Users/vivanac/Projects/picasso/migration-runs/2026-05-06/Button/worktree/migration-runs/2026-05-06/Button/report.md

See docs/migration/references/escalation.md for the full handoff procedure.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

📖 Storybook Preview

🚀 Your Storybook preview is ready: View Storybook

📍 Preview URL: https://toptal.github.io/picasso/prs/4906/

This preview is updated automatically when you push changes to this PR.

github-actions Bot added a commit that referenced this pull request May 6, 2026
@vedrani
Copy link
Copy Markdown
Collaborator

vedrani commented May 7, 2026

🛑 Orchestrator escalation — Switch

Trigger: gate did not pass after 5 iterations
Iterations: 5 / 3
PR: #4906
Worktree: (removed)
Last gate report: (none)

See docs/migration/references/escalation.md for the full handoff procedure.

@vedrani vedrani mentioned this pull request May 7, 2026
21 tasks
@vedrani
Copy link
Copy Markdown
Collaborator

vedrani commented May 7, 2026

🛑 Orchestrator escalation — Button

Trigger: gate did not pass after 5 iterations
Iterations: 5 / 3
PR: #4906
Worktree: (removed)
Last gate report: (none)

See docs/migration/references/escalation.md for the full handoff procedure.

@vedrani
Copy link
Copy Markdown
Collaborator

vedrani commented May 7, 2026

🛑 Orchestrator escalation — Button

Trigger: CI still failing after 5/5 iterations: Static checks, Integration Tests / Build packages
Iterations: 5 / 3
PR: #4906
Worktree: (removed)
Last gate report: /Users/vivanac/Projects/picasso/migration-runs/2026-05-07/Button/worktree/migration-runs/2026-05-07/Button/report.md

See docs/migration/references/escalation.md for the full handoff procedure.

@vedrani vedrani mentioned this pull request May 12, 2026
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants