TWE-22 | FE | Light mode#356
Merged
shyusu4 merged 10 commits intointegration/2024-evolutionfrom Feb 12, 2025
Merged
Conversation
Member
|
Nice work @shyusu4 - this is looking really good! 🙌 One small thing I noticed is that in high contrast light mode the active icon on the toggle doesn't remain visible: Details
Screen.Recording.2025-02-11.at.17.23.24.movAside from that it's all working as expected, nice one : ) |
Collaborator
Author
|
Thank you, @chris-lawton! I've commited the fix |
chris-lawton
approved these changes
Feb 12, 2025
Member
chris-lawton
left a comment
There was a problem hiding this comment.
All working - thanks @shyusu4!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Ticket
Description of Changes Made
How to Test
View the components through the pattern library at http://localhost:8000/pattern-library/render-pattern/patterns/styleguide/components/components.html
Screenshots
Expand to see more
MR Checklist
Unit tests
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library