Skip to content

TWE-22 | FE | Light mode#356

Merged
shyusu4 merged 10 commits intointegration/2024-evolutionfrom
feature/twe-22-light-mode
Feb 12, 2025
Merged

TWE-22 | FE | Light mode#356
shyusu4 merged 10 commits intointegration/2024-evolutionfrom
feature/twe-22-light-mode

Conversation

@shyusu4
Copy link
Collaborator

@shyusu4 shyusu4 commented Jan 30, 2025

Link to Ticket

Description of Changes Made

  • Re-added the dark/light mode toggle in the header
  • Added the light mode color variables for themes (colors for motifs were added in TWE-28 | FE | New motifs #355)
  • Modified featured services cards styles after design feedback from Ben E. (reduced line height for heading, mixin for the card hover style) And styled the subheading for TWE-9 - Add subheading to Featured Services Block #358
  • Fine tuned styling for components in light mode to match the figma design

How to Test

View the components through the pattern library at http://localhost:8000/pattern-library/render-pattern/patterns/styleguide/components/components.html

Screenshots

Expand to see more

Screenshot (192)
Screenshot (193)

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@shyusu4 shyusu4 marked this pull request as ready for review February 3, 2025 11:26
@shyusu4 shyusu4 requested a review from chris-lawton February 4, 2025 16:55
@chris-lawton
Copy link
Member

Nice work @shyusu4 - this is looking really good! 🙌

One small thing I noticed is that in high contrast light mode the active icon on the toggle doesn't remain visible:

Details

Screen.Recording.2025-02-11.at.17.23.24.mov

Aside from that it's all working as expected, nice one : )

@shyusu4
Copy link
Collaborator Author

shyusu4 commented Feb 12, 2025

Thank you, @chris-lawton! I've commited the fix

Copy link
Member

@chris-lawton chris-lawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working - thanks @shyusu4!

@shyusu4 shyusu4 merged commit b96867f into integration/2024-evolution Feb 12, 2025
4 checks passed
@shyusu4 shyusu4 deleted the feature/twe-22-light-mode branch February 12, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants