Skip to content

Allow moving a HistoricalWorkPage but disable creation#370

Merged
SharmaineLim merged 1 commit intointegration/2024-evolutionfrom
allow-moving-oldworkpage
Feb 27, 2025
Merged

Allow moving a HistoricalWorkPage but disable creation#370
SharmaineLim merged 1 commit intointegration/2024-evolutionfrom
allow-moving-oldworkpage

Conversation

@SharmaineLim
Copy link
Collaborator

@SharmaineLim SharmaineLim commented Feb 27, 2025

No ticket

Description of Changes Made

Currently, we cannot create nor move historical work pages.

While we still want to keep creation of these page types disabled, we want to be able to move them around to a different work index.

How to Test

Try to move a historical work page to a different work index page.

Screenshots

Screen recording
Screen.Recording.2025-02-27.at.1.09.52.PM.mov

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@SharmaineLim SharmaineLim merged commit 0895531 into integration/2024-evolution Feb 27, 2025
4 checks passed
@SharmaineLim SharmaineLim deleted the allow-moving-oldworkpage branch February 27, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant