Skip to content

Make the featured services heading required#425

Merged
helenb merged 1 commit intomainfrom
feature/TWE-691-featured-services-heading-required
Mar 23, 2026
Merged

Make the featured services heading required#425
helenb merged 1 commit intomainfrom
feature/TWE-691-featured-services-heading-required

Conversation

@helenb
Copy link
Copy Markdown
Member

@helenb helenb commented Mar 20, 2026

Link to Ticket

Description of Changes Made

Make the heading of the featured services block a required field, in order to prevent heading level mismatches.

How to Test

Edit a division page in your local build, and ensure you can't save a featured services block without a heading.

Screenshots

Expand to see more Screenshot 2026-03-20 at 12 56 19

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Performance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@helenb helenb requested a review from chris-lawton March 20, 2026 13:02
@helenb helenb merged commit 7546f96 into main Mar 23, 2026
4 checks passed
@helenb helenb deleted the feature/TWE-691-featured-services-heading-required branch March 23, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants