fix: share single SettingsViewModel to prevent duplicate monitoring#116
Merged
torlando-tech merged 1 commit intomainfrom Dec 17, 2025
Merged
Conversation
Multiple screens (SettingsScreen, MyIdentityScreen, IdentityScreen) were each creating their own SettingsViewModel via hiltViewModel(), causing each to start its own startSharedInstanceMonitor() loop. This resulted in 3-4 simultaneous polling loops every 5 seconds, significantly increasing battery drain. Fix: - Remove default hiltViewModel() from screen composables - Pass shared SettingsViewModel from MainActivity's NavHost - All screens now share one ViewModel instance = one monitoring loop Verified via logcat: now shows 1 check_shared_instance_available call per 5 seconds instead of 3-4 simultaneous calls. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
torlando-tech
deleted the
fix/duplicate-settingsviewmodel-battery-drain
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
check_shared_instance_availablecall per 5-second interval (previously 3-4)Changes
SettingsScreen.kt: Remove defaulthiltViewModel()for SettingsViewModelMyIdentityScreen.kt: Remove defaulthiltViewModel()for SettingsViewModelIdentityScreen.kt: Remove defaulthiltViewModel()for SettingsViewModelMainActivity.kt: Pass sharedsettingsViewModelto all screensSettingsViewModelTest.kt: Add tests for monitoring behavior🤖 Generated with Claude Code