Use server_hostname parameter in call to ssl_wrap_socket

[djvis]

No description provided.

[bdarnell]

Can you add a new test to TestIOStreamStartTLS that covers this error?

[djvis]

Sure. But not for a few days.

[djvis]

I've added a test test_check_hostname which attempts to call start_tls on a stream with the default SSL context and a server hostname of 127.0.0.1. This will catch the bug if it reappears in the future. However it does result in an SSL error due to verification failure (as far as I can tell the server isn't reporting a hostname).

Also, here is a gist showing how the error can be triggered: https://gist.github.com/djvis/2298e024ddda4e829808

[djvis]

Just noticed that the call to ssl.create_default_context is failing on several python versions. Will look for a solution now.

[djvis]

Turns out check_hostname functionality is only available in python 2.7 and 3.4 anyway. Have added a decorator to skip the test if the ssl module is missing the create_default_context function - which is a nice proxy for checking if python is of the required version.