fix run_sync no block problem#1314
Closed
huangwei1024 wants to merge 7 commits intotornadoweb:masterfrom
Closed
Conversation
···python @coroutine def _coroutine(): ret = yield rpc.call_async(method, *args) raise Return(ret) return self.ioloop.run_sync(_coroutine) ··· the example will raise `TimeoutError('Operation timed out after %s seconds' % timeout)` I modified `run_sync`, it will be run until future was done really or timeout.
Member
|
Can you provide a complete executable example that demonstrates the problem this solves? You shouldn't have to call start() more than once unless you're calling stop() somewhere that you shouldn't be. It sounds like you might be calling run_sync() while the IOLoop is already running, which won't work. |
Member
|
Closing because I can't reproduce any problem here; please reopen if you have more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the example will raise
TimeoutError('Operation timed out after %s seconds' % timeout)I modified
run_sync, it will be run until future was done really or timeout.