Closed
Conversation
Skip falsy values for some SimpleCookie flags
some modifications in demos/benchmark so it can run both in py2 and py3
The only remaining flake8 errors are for line length.
…hanges of the system time differently: * calculating next timeout value directly while advancing by a multiple of callback_time * when the system time changes, jumps into the future make the _schedule_next method do a busy wait. * on slow machines (RPi), jumps of a few months into the future can block the loop for a few minutes => added a check for big differences in current system time and the current value of the next scheduled timeout On a first boot of an older RPi image, tornado sometime starts before the date&time were updated through NTP, hence blocking the ioloop for several minutes.
Avoid busy waiting in ioloop when system time is skipped forward
Added logging for debugging and fixes for flake8
In Python 3 every exception has an auto-attached __context__ exception if it was raised while an existing exception was being handled. This is often a very useful property and allows users to see the underlying cause of many problems. However, when dealing with async code via coroutines this feature can suddenly become a pretty big issue. Namely, if you generator.throw back into a coroutine to raise an exception in the correct scope, and that coroutine raises an exception at a later time you can have nested exceptions which shouldn't logically be nested. This patch resolves this issue in the coroutine code by moving the gen.throw outside of the exception handler. By doing this the user-code scope is able to later raise exceptions without worrying about inheriting prior exception context.
flake8 cleanup
Coroutine exception __context__ leak in python 3
It is inexplicably failing on py27 DEPS=false while passing in other configurations.
Copied from Toro with small improvements.
Add tornado.locks.Condition.
This passes howsmyssl.com for python 2.7.9 and above; the older versions are fairly hopeless.
Copied from Toro with small improvements.
This allows it to be used with non-default options instances. Fixes #1342.
Add tornado.locks.Event.
The behavior of SSLSocket.send() with an unwriteable socket has changed: http://bugs.python.org/issue20951
Compare strings case-insensitively since the behavior of the cookie library has changed.
Unelss should be unless
Fix simple typo in httpclient exception message
Event cleanups.
Locale context (pgettext support)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IGNORE PLEASE