Fetch IOLoop in PeriodicCallback.start(), not __init__()#2179
Merged
bdarnell merged 1 commit intotornadoweb:masterfrom Oct 28, 2017
Merged
Fetch IOLoop in PeriodicCallback.start(), not __init__()#2179bdarnell merged 1 commit intotornadoweb:masterfrom
bdarnell merged 1 commit intotornadoweb:masterfrom
Conversation
pitrou
added a commit
to pitrou/distributed
that referenced
this pull request
Oct 30, 2017
pitrou
added a commit
to dask/distributed
that referenced
this pull request
Oct 31, 2017
* Fix PeriodicCallback usage for Tornado 5 The io_loop argument to PeriodicCallback is removed in Tornado 5.0. * Remove more io_loop argument references * Simplify compatibility code after tornadoweb/tornado#2179 was merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See motivation at dask/distributed#1172