Skip to content
This repository was archived by the owner on May 4, 2021. It is now read-only.

Ticket26740#231

Closed
juga0 wants to merge 3 commits intotorproject:masterfrom
juga0:ticket26740
Closed

Ticket26740#231
juga0 wants to merge 3 commits intotorproject:masterfrom
juga0:ticket26740

Conversation

@juga0
Copy link
Copy Markdown
Contributor

@juga0 juga0 commented Jul 10, 2018

No description provided.

teor2345
teor2345 reviewed Jul 10, 2018
View reviewed changes
Comment thread cron.d/sbws
# 35 * * * *
# 40 * * * *
# 45 * * * *
40 * * * * $SBWSBIN -d $SBWSHOME generate No newline at end of file
Copy link
Copy Markdown
Contributor

@teor2345 teor2345 Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do crontab files need to end in a newline?

Copy link
Copy Markdown
Member

@pastly pastly Jul 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge as soon as @juga0 answers and, if necessary, fixes.

Copy link
Copy Markdown
Contributor Author

@juga0 juga0 Jul 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not AFAIK, but i did not find documentation about it that confirms it.
I tested it works.

@juga0
Replace env var HOME by the home path
45c2a80 
and clarify this will be created by a system package
@juga0
Copy link
Copy Markdown
Contributor Author

juga0 commented Jul 13, 2018

I tested it works.

With the last commit, replace $HOME

@pastly
Copy link
Copy Markdown
Member

pastly commented Jul 13, 2018

Don't system packages usually put their homes in /var/lib?

If $HOME is set in the cron environment, wouldn't it be better to use $HOME so we don't have to remember to update that variable in this file?

@juga0
Copy link
Copy Markdown
Contributor Author

juga0 commented Jul 14, 2018 •
edited
Loading

Don't system packages usually put their homes in /var/lib?

yes, though since sbws does not require root to run, i was creating it having in mind that make install could be run by a user without root privileges.
However, while there isn't a generic Makefile that accepts prefix, and can be used as standalone or with system packages, this crontab files doesn't make much sense.
So probably we should close this as wontfix and the system package would take care of system configurations/files, or i should create a Makefile at least that manages the system files.
Will think about it a bit more.

Edit: fix typos

@juga0
Copy link
Copy Markdown
Contributor Author

juga0 commented Jul 16, 2018

Closing because of what commented above.
Instead document generate in PR #235

@juga0 juga0 closed this Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@teor2345 teor2345 teor2345 left review comments

@pastly pastly pastly left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juga0 @pastly @teor2345