Skip to content
This repository has been archived by the owner. It is now read-only.

Ticket26740 #231

Closed
wants to merge 3 commits into from
Closed

Ticket26740 #231

wants to merge 3 commits into from

Conversation

Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@juga0
Copy link
Contributor

@juga0 juga0 commented Jul 10, 2018

No description provided.

# 35 * * * *
# 40 * * * *
# 45 * * * *
40 * * * * $SBWSBIN -d $SBWSHOME generate
Copy link
Contributor

@teor2345 teor2345 Jul 10, 2018

Do crontab files need to end in a newline?

Copy link
Member

@pastly pastly Jul 11, 2018

I'll merge as soon as @juga0 answers and, if necessary, fixes.

Copy link
Contributor Author

@juga0 juga0 Jul 13, 2018

not AFAIK, but i did not find documentation about it that confirms it.
I tested it works.

and clarify this will be created by a system package
@juga0
Copy link
Contributor Author

@juga0 juga0 commented Jul 13, 2018

I tested it works.

With the last commit, replace $HOME

@pastly
Copy link
Member

@pastly pastly commented Jul 13, 2018

Don't system packages usually put their homes in /var/lib?

If $HOME is set in the cron environment, wouldn't it be better to use $HOME so we don't have to remember to update that variable in this file?

@juga0
Copy link
Contributor Author

@juga0 juga0 commented Jul 14, 2018

Don't system packages usually put their homes in /var/lib?

yes, though since sbws does not require root to run, i was creating it having in mind that make install could be run by a user without root privileges.
However, while there isn't a generic Makefile that accepts prefix, and can be used as standalone or with system packages, this crontab files doesn't make much sense.
So probably we should close this as wontfix and the system package would take care of system configurations/files, or i should create a Makefile at least that manages the system files.
Will think about it a bit more.

Edit: fix typos

@juga0
Copy link
Contributor Author

@juga0 juga0 commented Jul 16, 2018

Closing because of what commented above.
Instead document generate in PR #235

@juga0 juga0 closed this Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.