This repository has been archived by the owner. It is now read-only.
Log sbws version info line on startup #232
Merged
Conversation
juga0
suggested changes
Jul 13, 2018
except for the comments, lgtm
| @@ -7,6 +7,10 @@ | |||
| from sbws.util.config import validate_config | |||
| from sbws.util.config import configure_logging | |||
| from sbws.util.parser import create_parser | |||
| from sbws import __version__ as SBWS_VERSION | |||
| from stem import __version__ as STEM_VERSION | |||
| from requests.__version__ import __version__ as REQ_VERSION | |||
i'd just not use capitals here, since version is not in capitals.
I'd use as version for sbws version and stem_version, requests_version
|
Made variable name changes as requested and merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Produces a line such as the following.
[2018-07-11 11:27:35,464] [sbws.sbws] [INFO] sbws 0.6.1-dev with python 3.6.5 on Darwin-15.6.0-x86_64-i386-64bit, stem 1.6.0-dev, and requests 2.18.4The text was updated successfully, but these errors were encountered: