feat: [#279] add domain support for UDP trackers#280
Merged
Conversation
Add optional domain field to UDP tracker configuration to allow domain names in announce URLs instead of IP addresses. Changes: - Add domain field to UdpTrackerConfig (domain layer) - Add domain field to UdpTrackerSection (application DTO) - Update show command to use domain for UDP URLs when available - Regenerate JSON schema with new field - Update manual test env with UDP domain example - Update all test fixtures with domain: None
Member
Author
|
ACK a8bd087 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #279
Add optional
domainfield to UDP tracker configuration to allow domain names in announce URLs instead of IP addresses. This feature mirrors the existing domain support in HTTP trackers.Changes
Domain Layer (
src/domain/tracker/config/udp.rs)domain: Option<DomainName>field toUdpTrackerConfigApplication Layer
udp_tracker_section.rs: Adddomain: Option<String>field with validation usingDomainName::new()show/info/tracker.rs: Update to use domain for UDP URLs when availableInfrastructure Layer
domain: Nonefor existing UDP tracker constructionsSchema & Config
domainfield descriptionenvs/manual-https-test.jsonwith example UDP domainTesting
Example Usage
{ "trackers": [ { "name": "udp1", "udp": { "bind_port": 6969, "public_port": 6969, "domain": "udp1.tracker.example.com" } } ] }Before/After
Before: UDP URLs used IP addresses only
After: UDP URLs use domain when configured