Skip to content

Overhaul core Tracker: add tests for authentication mod #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
josecelano merged 18 commits into from
Feb 4, 2025
Merged

Overhaul core Tracker: add tests for authentication mod #1232

josecelano merged 18 commits into from
Feb 4, 2025

Conversation

@josecelano
Copy link
Member

@josecelano josecelano commented Feb 3, 2025 •
edited
Loading

Overhaul core Tracker: add tests for authentication mod.

Coverage before:

Filename                                                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
packages/tracker-core/src/authentication/handler.rs                              85                17    80.00%          28                 1    96.43%         203                35    82.76%           0                 0         -
packages/tracker-core/src/authentication/key/mod.rs                              55                 7    87.27%          18                 3    83.33%         124                12    90.32%           0                 0         -
packages/tracker-core/src/authentication/key/repository/in_memory.rs             23                 5    78.26%          10                 2    80.00%          25                 5    80.00%           0                 0         -
packages/tracker-core/src/authentication/key/repository/persisted.rs             15                 3    80.00%           4                 0   100.00%          17                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/mod.rs                                  67                 0   100.00%          19                 0   100.00%         201                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/service.rs                              22                 2    90.91%

Coverage after:

Filename                                                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
packages/tracker-core/src/authentication/handler.rs                             158                 9    94.30%          52                 0   100.00%         583                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/key/mod.rs                              35                 3    91.43%          11                 0   100.00%          96                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/key/peer_key.rs                         39                 0   100.00%          17                 0   100.00%         102                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/key/repository/in_memory.rs             51                 0   100.00%          20                 0   100.00%         169                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/key/repository/persisted.rs             24                 2    91.67%           8                 0   100.00%          77                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/mod.rs                                  67                 0   100.00%          19                 0   100.00%         219                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/service.rs                              52                 0   100.00%          20                 0   100.00%         268                 0   100.00%           0                 0         -

@josecelano josecelano self-assigned this Feb 3, 2025
@josecelano josecelano added Quality & Assurance Relates to QA, Testing, and CI - Developer - Torrust Improvement Experience Testing Checking Torrust labels Feb 3, 2025
@josecelano josecelano linked an issue Feb 3, 2025 that may be closed by this pull request
Overhaul core Tracker: add tests for authentication mod #1231
Closed
@josecelano josecelano requested a review from da2ce7 February 3, 2025 10:35
@josecelano josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from dc4e44d to 8efda62 Compare February 3, 2025 10:36
@josecelano josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from 8397033 to f9bcb79 Compare February 3, 2025 11:30
@josecelano josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from f9bcb79 to 7c8d294 Compare February 3, 2025 11:30
@josecelano josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from a2bbdec to 8709540 Compare February 3, 2025 12:18
@josecelano josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from 218dc14 to abd7bca Compare February 4, 2025 10:31
@josecelano josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from abd7bca to b40de68 Compare February 4, 2025 11:14
@josecelano josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from b40de68 to bd4cef6 Compare February 4, 2025 11:17
@josecelano josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from 1e6b8bf to 7d8b394 Compare February 4, 2025 13:07
@josecelano josecelano marked this pull request as ready for review February 4, 2025 13:18
@josecelano
Copy link
Member Author

josecelano commented Feb 4, 2025

ACK 3d89c7f

@josecelano josecelano merged commit 4a9c083 into torrust:develop Feb 4, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees

@josecelano josecelano

Labels

- Developer - Torrust Improvement Experience Quality & Assurance Relates to QA, Testing, and CI Testing Checking Torrust

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Overhaul core Tracker: add tests for authentication mod

1 participant

@josecelano