Skip to content

chore(issues): archive closed specs #669, #1771, #1778 and fix pre-push spec numbering (#1770 → #1780)#1781

Merged
josecelano merged 1 commit into
torrust:developfrom
josecelano:chore/cleanup-issue-specs
May 13, 2026
Merged

chore(issues): archive closed specs #669, #1771, #1778 and fix pre-push spec numbering (#1770 → #1780)#1781
josecelano merged 1 commit into
torrust:developfrom
josecelano:chore/cleanup-issue-specs

Conversation

@josecelano
Copy link
Copy Markdown
Member

Summary

Maintenance cleanup of docs/issues/ to keep the open/ folder aligned with GitHub issue states.

Changes

Archive closed issue specs (Stage 1)

Move specs from docs/issues/open/ to docs/issues/closed/ for issues closed on 2026-05-13:

Fix incorrectly numbered pre-push spec

The file 1770-refactor-pre-push-checks-performance-and-verbosity.md was accidentally named
after PR #1770 (a docs-only PR that moved specs for #1768 and #1769 to open/). No GitHub issue
existed for this spec (github-issue: null in frontmatter).

  • Created new GitHub issue #1780
  • Renamed file: 1770-…1780-refactor-pre-push-checks-performance-and-verbosity.md
  • Updated frontmatter: github-issue, spec-path, branch, last-updated-utc
  • Updated spec title from #[To be assigned] to #1780

Validation

  • linter all passes

…t#1778 and fix pre-push spec numbering

- Move docs/issues/open/669-overhaul-clients.md to closed/
  (issue torrust#669 was closed on 2026-05-13 after torrust#1771 merged)
- Move docs/issues/open/1771-merge-clients-into-unified-tracker-client-cli.md to closed/
  (issue torrust#1771 was closed on 2026-05-13)
- Move docs/issues/open/1778-migrate-to-rust-edition-2024.md to closed/
  (issue torrust#1778 was closed on 2026-05-13)
- Rename docs/issues/open/1770-refactor-pre-push-checks-performance-and-verbosity.md
  to 1780-refactor-pre-push-checks-performance-and-verbosity.md
  (1770 was a PR number, not an issue; GitHub issue torrust#1780 has now been opened for this spec)
@josecelano josecelano requested a review from Copilot May 13, 2026 17:38
@josecelano josecelano self-assigned this May 13, 2026
@josecelano
Copy link
Copy Markdown
Member Author

ACK 08446dd

@josecelano josecelano merged commit 44a44b6 into torrust:develop May 13, 2026
3 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs maintenance on docs/issues/ to keep the open/ and closed/ folders aligned with GitHub issue state, and fixes an incorrectly numbered pre-push spec by updating it to issue #1780.

Changes:

  • Archive closed issue specs by moving them into docs/issues/closed/ (#669, #1771, #1778).
  • Fix pre-push spec numbering by updating metadata/title to issue #1780.
  • Refresh issue-spec metadata (frontmatter fields like github-issue, spec-path, branch, last-updated-utc).

Reviewed changes

Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.

File Description
docs/issues/open/1780-refactor-pre-push-checks-performance-and-verbosity.md Updates frontmatter and heading to reflect GitHub issue #1780.
docs/issues/closed/669-overhaul-clients.md Adds archived EPIC spec for #669 into the closed buffer.
docs/issues/closed/1778-migrate-to-rust-edition-2024.md Adds archived issue spec for #1778 into the closed buffer.
docs/issues/closed/1771-merge-clients-into-unified-tracker-client-cli.md Adds archived issue spec for #1771 into the closed buffer.
Comments suppressed due to low confidence (1)

docs/issues/open/1780-refactor-pre-push-checks-performance-and-verbosity.md:10

  • last-updated-utc is set to 2026-05-13 17:55, which is later than the current timestamp provided for this PR review (2026-05-13T17:38:48Z). Please update it to an accurate non-future UTC time.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

josecelano added a commit that referenced this pull request May 13, 2026
…entally closed)

f75f2c6 docs(skills): add PR-to-issue linking rules to open-pull-request and create-issue (Jose Celano)
559bb1a fix(issues): restore 1778 spec to open/ (issue was accidentally closed) (Jose Celano)

Pull request description:

  ## Summary

  Two fixes triggered by issue #1778 being accidentally closed when a spec-only PR was merged.

  ## Changes

  ### 1. Restore 1778 spec to `open/`

  `docs/issues/open/1778-migrate-to-rust-edition-2024.md` was moved to `closed/` in PR #1781
  because issue #1778 appeared closed on GitHub. It was closed automatically when a PR containing
  the issue spec used `Closes #1778` in the body. The implementation has **not** been done yet.

  Issue #1778 has been reopened on GitHub.

  ### 2. Add PR-to-issue linking rules to skills

  Update `open-pull-request` and `create-issue` skills to prevent the same mistake in the future:

  - **`open-pull-request/SKILL.md`**: replace the single `Closes #N` rule with an
    "Issue Linking Rules" section containing a decision table (`Related to` vs `Closes`)
    and a diff-based check to identify the PR type. Update the post-creation checklist.
  - **`create-issue/SKILL.md`**: add the `Related to #N` warning in the spec-first workflow
    overview and in Step 6 (spec-only PR), with a cross-reference to the `open-pull-request` skill.

  **Rule added:**

  | PR type | Keyword |
  | ------- | ------- |
  | Spec-only (no implementation) | `Related to #N` |
  | Implementation (with or without spec) | `Closes #N` |

  ## Validation

  - `linter markdown` passes
  - `linter cspell` passes

ACKs for top commit:
  josecelano:
    ACK f75f2c6

Tree-SHA512: 938e13ac36ecef7f0b0d47be6887c535a6ef35ba20fa89b410838104ac588d182bc0a02fc8dc35dd94fbaee4ead3e7dd0e0c34bff97e76075e5cbc29efbf5bcb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants