fix(containerfile): add --locked flag to cargo binstall calls for cargo-nextest#1850
Merged
josecelano merged 2 commits intoJun 1, 2026
Conversation
…go-nextest cargo-nextest requires --locked when built from source (enforced by the locked-tripwire crate). When cargo-binstall falls back to source compilation it calls 'cargo install' without --locked, triggering a compile-time error. Passing --locked to cargo-binstall propagates the flag to the underlying cargo install invocation, fixing the Container workflow build failure.
There was a problem hiding this comment.
Pull request overview
This PR fixes the failing container build by ensuring cargo-nextest can be installed even when cargo-binstall falls back to compiling from source, by forwarding --locked to the underlying cargo install invocation.
Changes:
- Add
--lockedto thecargo binstallinvocation in thechefstage (installingcargo-chefandcargo-nextest). - Add
--lockedto thecargo binstallinvocation in thetesterstage (installingcargo-nextest).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1850 +/- ##
===========================================
- Coverage 77.85% 77.80% -0.05%
===========================================
Files 380 380
Lines 28647 28648 +1
Branches 28647 28648 +1
===========================================
- Hits 22304 22291 -13
- Misses 6036 6052 +16
+ Partials 307 305 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…rait impls Four async trait impl functions in rw_lock_std_mutex_tokio.rs had no .await expressions, triggering clippy::unused_async_trait_impl (-D clippy::pedantic). Replace async fn with fn returning impl Future<Output = ...> + Send using std::future::ready(), matching the trait signature and removing the unnecessary async overhead.
Member
Author
|
ACK 0baeaba |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Containerworkflow started failing after the last merged PR with:cargo-nextestenforces installation with--lockedat compile time via thelocked-tripwirecrate. Whencargo-binstallcannot find a pre-built binary and falls back to source compilation, it callscargo installwithout--locked, triggering this compile-time error.Fix
Add
--lockedto bothcargo binstallinvocations in theContainerfile(thechefandtesterimage stages). This flag is forwarded bycargo-binstallto the underlyingcargo installcall when falling back to source compilation.Changes
Containerfile:cargo binstall --no-confirm→cargo binstall --no-confirm --locked(both occurrences)