Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #270 (B1) by removing eager output-directory creation during analysis initialization and shifting directory creation closer to actual export/save actions.
Changes:
- Removed
os.makedirs(...)side effect fromAnalyzer.__init__. - Added a helper (
outdir_set) and updated many save calls to create the output directory on-demand. - Updated
World.show_networkto only create the output directory whensave_modeis enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uxsim/uxsim.py | Makes show_network() create the output directory only when saving is enabled. |
| uxsim/analyzer.py | Removes directory creation from Analyzer.__init__ and adds a lazy directory-creation helper used by export routines. |
Comment on lines
+95
to
+96
| os.makedirs(f"out{s.W.name}", exist_ok=True) | ||
| return fname |
There was a problem hiding this comment.
outdir_set() always creates out{s.W.name} regardless of the directory in fname. This breaks network_anim()/network_fancy() when file_name points to a different directory (the target directory may not exist) and also reintroduces an unintended side effect (creating out...) even when saving elsewhere. Consider creating Path(fname).parent (when non-empty) instead of hard-coding out{s.W.name}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses B1 of #270