Skip to content

Speed up homogeneous_DUO_update#89

Merged
toruseo merged 5 commits intomainfrom
develop
Jul 29, 2024
Merged

Speed up homogeneous_DUO_update#89
toruseo merged 5 commits intomainfrom
develop

Conversation

@toruseo
Copy link
Owner

@toruseo toruseo commented Jul 29, 2024

No description provided.

@toruseo toruseo merged commit b3a6574 into main Jul 29, 2024
@EwoutH
Copy link
Contributor

EwoutH commented Jul 29, 2024

Really awesome! I will run a quick test tomorrow on my model.

One small suggestion: It would be nice to keep PRs somewhat atomic, meaning they each contain one distinct feature or change. That makes following and potentially reviewing changes much easier, as well as tracking down accidental bugs.

@toruseo
Copy link
Owner Author

toruseo commented Jul 29, 2024

You mean the commit "Update font specifications" is not relevant? Actually, it is related to the other commits (although I am not sure if I can say atomic). In the commit "fine-tune for large-scale simulation", which is a preparation for the vectorization, I have optimized font loading function. But it introduced some deprecation warning, so I fixed them in the commit "Update font specifications" and make this PR.

Anyway, thanks for your continuous help and feedbacks! Now we can simulate and visualize 1 million vehicles in Chicago metropolitan area in 1 minute!

anim_network_fancy_chicago_sketch_resized

@EwoutH
Copy link
Contributor

EwoutH commented Jul 29, 2024

This is really impressive! I will be simulating the Rotterdam region, with hundreds of thousands vehicles, and now I might be able to run locally instead of needing to reserve our supercomputer for extensive time.

It's always nice when open-source proves again life isn't a zero-sum game!

@EwoutH
Copy link
Contributor

EwoutH commented Jul 29, 2024

Could you tag a new version with this speedup?

@toruseo
Copy link
Owner Author

toruseo commented Jul 30, 2024

released as v1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants