Skip to content

fix: preserve exports with same symbolName but different kind in excludeBarrelReExports #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zih0 merged 1 commit into from
Mar 25, 2026
Merged

fix: preserve exports with same symbolName but different kind in excludeBarrelReExports #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/core/parser/source/exclude-barrel-re-exports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { groupBy } from "es-toolkit";
import { ExportDeclaration } from "../../types/parser.types.js";

export function excludeBarrelReExports(exportDeclarations: ExportDeclaration[]): ExportDeclaration[] {
return Object.values(groupBy(exportDeclarations, exp => exp.symbolName))
return Object.values(groupBy(exportDeclarations, exp => `${exp.symbolName}:${exp.kind}`))
.flatMap(declarations => {
if (declarations.length === 1) {
return declarations;
Expand Down
16 changes: 16 additions & 0 deletions packages/cli/src/tests/core/parser/source/exclude-barrel-re-exports.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { getExportedDeclarationsBySourceFile } from "../../../../core/parser/sou
import { getTsProject } from "../../../../core/get-ts-project.js";
import { getTsConfigPath } from "../../../../core/get-ts-config-path.js";
import { createE2EWorkspace, E2EWorkspace } from "../../../utils/create-e2e-workspace.js";
import { ExportDeclaration, StandardizedFilePath } from "../../../../core/types/parser.types.js";

describe("excludeBarrelReExports", () => {
let workspace: E2EWorkspace;
Expand Down Expand Up @@ -92,4 +93,19 @@ describe("excludeBarrelReExports", () => {
expect(filePaths.some(path => path.includes("math.ts"))).toBe(true);
expect(filePaths.some(path => path.includes("string.ts"))).toBe(true);
});

it("should keep both exports when symbolName is same but kind differs", () => {
const result = excludeBarrelReExports([
mockExport("Foo", "type", "/src/foo.ts"),
mockExport("Foo", "function", "/src/foo.ts"),
]);

expect(result).toHaveLength(2);
expect(result.find(exp => exp.kind === "type")).toBeDefined();
expect(result.find(exp => exp.kind === "function")).toBeDefined();
});
});

function mockExport(symbolName: string, kind: ExportDeclaration["kind"], filePath: string): ExportDeclaration {
return { symbolName, kind, filePath: filePath as StandardizedFilePath } as ExportDeclaration;
}
Loading