feat(bench): Add @napi-rs/simple-git to benchmarks#76
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
benchmarks/package.json
Outdated
| "dependencies": { | ||
| "nodegit": "link:./nodegit" | ||
| "nodegit": "link:./nodegit", | ||
| "simple-git": "link:./simple-git" |
There was a problem hiding this comment.
Since, @napi-rs/simple-git not uses node-gyp and includes prebuilt across all platforms, how about installing it directly with the yarn workspace module?
| "simple-git": "link:./simple-git" | |
| "@napi-rs/simple-git": "0.1.19" |
There was a problem hiding this comment.
Oh, I thought it's conversion of benchmark folder.
I'll change it when I possible to work.
There was a problem hiding this comment.
Since nodegit does not have a prebuilt for workspaces Node.js version, so installation with the yarn workspace module may be failed depending on the users environment. Therefore, we are safely separating the package and installing it manually. 😭
For detailed instructions, please refer to benchmarks/README.md.
There was a problem hiding this comment.
@seokju-na I updated commit for this review
benchmarks/index.bench.ts
Outdated
| await NodeGitRepository.open(gitDir); | ||
| }); | ||
|
|
||
| bench('simple-git', () => { |
There was a problem hiding this comment.
| bench('simple-git', () => { | |
| bench('@napi-rs/simple-git', () => { |
Could you please be more specific about the name, as it may overlap with other packages? (e.g. https://github.com/steveukx/git-js/tree/main/simple-git)
|
Greate jobs. Thanks for your contribution! |
|
Could you please check for CI failures? |
* feat(bench): Add `@napi-rs/simple-git` to benchmarks (toss#76) Co-authored-by: seokju-na <seokju.me@toss.im> * chore(docs): fix some typos * test --------- Co-authored-by: Noel Kim (김민혁) <noelkim@prestolabs.io> Co-authored-by: seokju-na <seokju.me@toss.im>
|
Benchmark updated from #101 |
3 participants
I added
@napi-rs/simple-gitbenchmark for test performanceNOTE
Need to update benchmark results with maintainer's laptop.