Skip to content

docs: fix correct style prop usage and prop passing in ItemEditModal composition example #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milooy merged 2 commits into from
Sep 8, 2025
Merged

docs: fix correct style prop usage and prop passing in ItemEditModal composition example #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1da4ec0
docs: fix correct style prop usage and prop passing in ItemEditModal …
wo-o29 Sep 1, 2025
8f13919
docs: Fixed example code highlighting
wo-o29 Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 10 additions & 17 deletions fundamentals/code-quality/code/examples/item-edit-modal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function ItemEditModal({ open, items, recommendedItems, onConfirm, onClose }) {

return (
<Modal open={open} onClose={onClose}>
<ItemEditBody
<ItemEditBody
keyword={keyword}
onKeywordChange={setKeyword}
onClose={onClose}
Expand All @@ -111,7 +111,7 @@ function ItemEditModal({ open, items, recommendedItems, onConfirm, onClose }) {
function ItemEditBody({ children, keyword, onKeywordChange, onClose }) {
return (
<>
<div style="display: flex; justify-content: space-between;">
<div style={{ display: "flex", justifyContent: "space-between" }}>
Copy link
Collaborator

@milooy milooy Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

<Input
value={keyword}
onChange={(e) => onKeywordChange(e.target.value)}
Expand All @@ -135,34 +135,27 @@ Context API를 활용하면, 데이터의 흐름을 간소화하고 계층 구

조합 패턴을 사용해도, 컴포넌트가 복잡하고 깊다면, ContextAPI를 사용함으로써 불필요한 Props Drilling을 제거할 수 있어요.

```tsx 1,7,14
```tsx 1,11,18
function ItemEditModal({ open, onConfirm, onClose }) {
const [keyword, setKeyword] = useState("");

return (
<Modal open={open} onClose={onClose}>
<ItemEditBody onClose={onClose}>
<ItemEditBody
keyword={keyword}
onKeywordChange={setKeyword}
onClose={onClose}
>
<ItemEditList keyword={keyword} onConfirm={onConfirm} />
</ItemEditBody>
</Modal>
);
}

function ItemEditList({ children, onClose }) {
function ItemEditList({ keyword, onConfirm }) {
const { items, recommendedItems } = useItemEditModalContext();

return (
<>
<div style="display: flex; justify-content: space-between;">
<Input
value={keyword}
onChange={(e) => onKeywordChange(e.target.value)}
/>
<Button onClick={onClose}>닫기</Button>
</div>
{children}
</>
);
return <>{/* items, recommendedItems 렌더링 로직 */}</>;
}
```

Expand Down
33 changes: 15 additions & 18 deletions fundamentals/code-quality/ja/code/examples/item-edit-modal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,11 @@ function ItemEditModal({ open, items, recommendedItems, onConfirm, onClose }) {

return (
<Modal open={open} onClose={onClose}>
<ItemEditBody onClose={onClose}>
<ItemEditBody
keyword={keyword}
onKeywordChange={setKeyword}
onClose={onClose}
>
<ItemEditList
keyword={keyword}
items={items}
Expand All @@ -101,10 +105,10 @@ function ItemEditModal({ open, items, recommendedItems, onConfirm, onClose }) {
);
}

function ItemEditBody({ children, onClose }) {
function ItemEditBody({ children, keyword, onKeywordChange, onClose }) {
return (
<>
<div style="display: flex; justify-content: space-between;">
<div style={{ display: "flex", justifyContent: "space-between" }}>
<Input
value={keyword}
onChange={(e) => onKeywordChange(e.target.value)}
Expand All @@ -127,34 +131,27 @@ function ItemEditBody({ children, onClose }) {
Context APIを活用することで、データの流れを簡素化し、階層構造全体に簡単に共有することができます。
コンポジションパターンを使用しても、コンポーネントが複雑で深い場合には、ContextAPIを使用することで不必要なProps Drillingを取り除くことができます。

```tsx 1,7,14
```tsx 1,11,18
function ItemEditModal({ open, onConfirm, onClose }) {
const [keyword, setKeyword] = useState("");

return (
<Modal open={open} onClose={onClose}>
<ItemEditBody onClose={onClose}>
<ItemEditBody
keyword={keyword}
onKeywordChange={setKeyword}
onClose={onClose}
>
<ItemEditList keyword={keyword} onConfirm={onConfirm} />
</ItemEditBody>
</Modal>
);
}

function ItemEditList({ children, onClose }) {
function ItemEditList({ keyword, onConfirm }) {
const { items, recommendedItems } = useItemEditModalContext();

return (
<>
<div style="display: flex; justify-content: space-between;">
<Input
value={keyword}
onChange={(e) => onKeywordChange(e.target.value)}
/>
<Button onClick={onClose}>閉じる</Button>
</div>
{children}
</>
);
return <>{/* items, recommendedItems レンダリングロジック */}</>;
}
```

Expand Down