docs: fix correct style prop usage and prop passing in ItemEditModal composition example #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wo-o29 is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
milooy
approved these changes
Sep 8, 2025
| return ( | ||
| <> | ||
| <div style="display: flex; justify-content: space-between;"> | ||
| <div style={{ display: "flex", justifyContent: "space-between" }}> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Key Changes
Corrected style prop usage:
Updated inline style from
style="display: flex; justify-content: space-between;"tostyle={{ display: "flex", justifyContent: "space-between" }}for valid JSX and consistency.Added missing keyword prop:
Passed the required
keywordprop toItemEditBodyfor controlled input, ensuring correct state management and preventing uncontrolled behavior.Fixed
ItemEditListprops and example comment:Adjusted props for
ItemEditListto match the component's usage, removing unrelated props fromItemEditBody.This change applies to Korean and Japanese documents.
💬 Comment
Since ItemEditList is an example that shows how to use the Context API, the rendering logic is simply written in comments, but if you need the exact code, please let me know!
🖼️ Before and After Comparison