Skip to content

fix(plugin-router): preserve default watch option#294

Merged
jingjing2222 merged 1 commit into
toss:mainfrom
juntak45:fix/plugin-router-watch-default
May 12, 2026
Merged

fix(plugin-router): preserve default watch option#294
jingjing2222 merged 1 commit into
toss:mainfrom
juntak45:fix/plugin-router-watch-default

Conversation

@juntak45
Copy link
Copy Markdown
Contributor

Summary

  • preserve watch: true when router({}) is called with an empty options object
  • add a focused regression test for the plugin dev handler
  • add a patch changeset for @granite-js/plugin-router

Test plan

  • yarn workspace @granite-js/plugin-router test src/routerPlugin.spec.ts
  • yarn workspace @granite-js/plugin-router test
  • yarn workspace @granite-js/plugin-core build
  • yarn workspace @granite-js/plugin-router typecheck
  • yarn eslint packages/plugin-router/src/routerPlugin.ts packages/plugin-router/src/routerPlugin.spec.ts
  • yarn workspace @granite-js/plugin-router build

@vercel
Copy link
Copy Markdown

vercel Bot commented May 12, 2026

@juntak45 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 12, 2026

🦋 Changeset detected

Latest commit: e1b220c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@granite-js/plugin-router Patch
babel-preset-granite Patch
create-granite-app Patch
@granite-js/blur-view Patch
@granite-js/brownfield-module Patch
@granite-js/cli Patch
@granite-js/cookies Patch
@granite-js/screen Patch
@granite-js/image Patch
@granite-js/jest Patch
@granite-js/lottie Patch
@granite-js/mpack Patch
@granite-js/native Patch
@granite-js/naver-map Patch
@granite-js/plugin-core Patch
@granite-js/plugin-env Patch
@granite-js/plugin-hermes Patch
@granite-js/plugin-micro-frontend Patch
@granite-js/plugin-rozenite Patch
@granite-js/plugin-sentry Patch
@granite-js/react-native Patch
@granite-js/style-utils Patch
@granite-js/utils Patch
@granite-js/video Patch
@granite-js/vitest Patch
@granite-js/deployment-manager Patch
@granite-js/forge-cli Patch
@granite-js/pulumi-aws Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Collaborator

@jingjing2222 jingjing2222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingjing2222 jingjing2222 merged commit 90ffc5f into toss:main May 12, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants