Fixed RDP display scaling issue#207
Conversation
|
sorry) just fixed. Please recheck according to your fixes |
|
I see that your implementation is the opposite of mine. I actually request a lower resolution during scaling to save bandwidth, which I think makes more sense than pushing 4K over the network if system scaling is selected in the protocol settings. However, I will take your other changes. Thank you. I will apply them in the next release and merge. You don't need to change anything on your end. |
|
I think it would make sense to lock both options behind a toggle in the remote connection settings. Then this follows the same logic as RoyalTS has when you select "Use full retina resolution" and the user can decide to save bandwith or go full eyecandy. This would be the one RDP feature that Remmina does not deliver and a great feature for all users with HiDPI screens working remote. What do you think? |
Extend ScaleOverride with a Native variant that follows the display's live scale_factor() for a full-resolution remote desktop, adapting across differently-scaled monitors. Replaces the compile-time effective_scale() with resolved_scale(system_scale); Auto stays the bandwidth-saving logical default. Applies to both embedded RDP and VNC.
|
Thanks again for this, @dwetscher! Your fixes landed in v0.18.0 - I reworked them slightly to keep
All three credit you in the CHANGELOG (“Based on the contribution by @dwetscher”). Since I applied them as reworked commits rather than a direct merge, I'm closing this PR - but the work is very much in the release. Much appreciated! |
2 participants
Fixed a problem with RDP connections not sending the correct display scaling setting to the RDP server, resulting in 100% scaled RDP connections on e.g. 200% scaled screens (very small). This is a problem introduced with the last PR about RDP connections not using the full available screen space. Since I did not have a proper 5k screen to test available yesterday, this did not come up as a problem.
Now tested on a 5k screen with 200% scaling = RDP connection with nice crisp 200% scaling. 100% scaled laptop screen tested as well, results in 100% scale on RDP.
Let me know if this needs any further testing, maybe also check on your end, it is absolutely not my intention to introduce new bugs to the project, sorry about this.
Thanks