Skip to content

upgrades/24.09.01: only add step to update Upgrader if there is an Upgrader#380

Merged
totten merged 1 commit intototten:masterfrom
semseysandor:upgrade-24-09-1
Jan 18, 2025
Merged

upgrades/24.09.01: only add step to update Upgrader if there is an Upgrader#380
totten merged 1 commit intototten:masterfrom
semseysandor:upgrade-24-09-1

Conversation

@semseysandor
Copy link
Copy Markdown
Contributor

If an extension has no Upgrader defined in info.xml, this upgrade step will tell that:

Update info.xml to use CiviMix\Schema\{MyExtension}\AutomaticUpgrader

but it won't do it.

It's just confusing for the user.
In this PR, the displayed planned actions are matched to the actual ones.

@totten
Copy link
Copy Markdown
Owner

totten commented Jan 18, 2025

Quite right! If they don't have an <upgrader> or any other hints at defining entities... then we really don't need to show that message.

@totten totten merged commit 351e988 into totten:master Jan 18, 2025
@semseysandor semseysandor deleted the upgrade-24-09-1 branch January 18, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants