Merge --yes with the more conventional --no-interaction#393
Merged
Conversation
Closed
* Before Civix::io() was available, the `AbstractCommand` had a helper called `confirm(). * However, this helper could only be used directly within a `Command` class. * Now, with Civix::io(), it's reuse helpers in many contexts (commands, generators, upgraders, etc)
totten
force-pushed
the
master-confirm-b
branch
from
c780766 to
c15198c
Compare
Contributor
|
Great, thanks @totten |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Address the inconsistent behavior of
--yesby using the (more consistent) option--no-interaction.Fix #391
Before
civixinherits the option--no-interaction(-n) from Symfony Console.civixalso defines the option--yes, but this is only used for 1-2 prompts. Most prompts ignore it.Commandclasses to theGenerator.)After
civixstill inherits the option--no-interaction(-n) from Symfony Console.civix --yesis a deprecated alias forcivix --no-interaction.