Update civixmix-schema from 5.80.2=>5.85.beta1#403
Merged
Conversation
Owner
Author
I think as currently written this bit would require 5.74+, but the tests are passing because there's no coverage for So I should probably add some coverage for the new function. After that, I strongly suspect one of these would get 5.69 (actually, 5.45) compat: -$tableName = \Civi::entity($entityName)->getMeta('table');
+$tableName = CRM_Core_DAO_AllCoreTables::getTableForEntityName($entityName)-$tableName = \Civi::entity($entityName)->getMeta('table');
+$tableName = method_exists('Civi', 'entity')
+ ? \Civi::entity($entityName)->getMeta('table')
+ : CRM_Core_DAO_AllCoreTables::getTableForEntityName($entityName)But first, test-coverage... |
bfdbaf6 to
c4d1fe4
Compare
Owner
Author
|
New revision just adds some test-coverage. Should see it failing in a few places. (After that, I've got a draft revision with compatibility fix...) |
Owner
Author
|
Test now passes here (but with a small patch for |
Contributor
|
Cool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should add new helpers from https://github.com/civicrm/civicrm-core/pull/32603/files.
TODO: Assess backward-compatibility. (Hopefully, the CI tests will give some clue... 🤞)