generate:search - Drop generator for deprecated subsystem#413
Merged
Conversation
totten
changed the title
generate:search actiongenerate:search - Drop generator for deprecated subsystem
Contributor
|
@totten looks like it was straightforward to remove 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
generate:searchcommand creates a skeletal subclass based onCRM_Contact_Form_Search_Custom_Base.However, the entire subsystem was deprecated circa 2021 (~5.41), when it started moving into a core-extension (
legacycustomsearches). The deprecation became more meaningful with the evolution of "Search Kit" -- there is now little reason for anyone to usegenerate:search.Additionally, the generator is now a bit quirky -- it will create class-files, but you have to manually enable the dependency
legacycustomsearches(for 5.41+).Let's see if it's easy to remove...