LogcatWriter fails with UnsatisfiedLinkError on Android JVM test

[angusholder]

Looks like LogcatWriter is intended to handle the Log class being unavailable in an Android module JVM unit test, but it's throwing UnsatisfiedLinkError, which is not a subclass of Exception which LogcatWriter catches.

Kermit/kermit-core/src/androidMain/kotlin/co/touchlab/kermit/LogcatWriter.kt

Lines 48 to 50 in 42ff100

	} catch (_: Exception) {
	testWriter.log(severity, message, tag, throwable)
	}

java.lang.UnsatisfiedLinkError: 'int android.util.Log.println_native(int, int, java.lang.String, java.lang.String)'
	at android.util.Log.println_native(Native Method)
	at android.util.Log.d(Log.java:172)
	at co.touchlab.kermit.LogcatWriter.log(LogcatWriter.kt:28)
	at co.touchlab.kermit.BaseLogger.processLog(BaseLogger.kt:55)
	<snip>

Should it be changed to catch all Throwable? Or add a specific catch UnsatisfiedLinkError?

I'm on version 2.1.0

[angusholder]

I tried cloning your repo and adding a test to reproduce the issue, but to my confusion it works correctly in your repo:

import java.io.ByteArrayOutputStream
import java.io.PrintStream
import kotlin.test.Test
import kotlin.test.assertEquals

// Purposely run without Robolectric, to check we support plain JVM unit tests in an Android module
@OptIn(ExperimentalKermitApi::class)
class JvmLogcatLoggerTest {

    private val testConfig = TestConfig(
        minSeverity = Severity.Verbose,
        logWriterList = listOf(LogcatWriter()),
    )

    private fun captureStdout(block: () -> Unit): String {
        val existingOut: PrintStream = System.out
        val capturedStdout = ByteArrayOutputStream()
        System.setOut(PrintStream(capturedStdout))
        try {
            block()
        } finally {
            System.setOut(existingOut)
        }
        return capturedStdout.toString(Charsets.UTF_8)
    }

    @Test
    fun logsToStdoutTest() {
        val logger = BaseLogger(testConfig)

        val logOutput = captureStdout {
            logger.log(Severity.Debug, "tag", null, "Message")
        }
        assertEquals("Debug: (tag) Message\n", logOutput)
    }
}

Log.d() is throwing RuntimeException: Method d in android.util.Log not mocked. in your project, whereas it throws UnsatisfiedLinkError in mine. My android.util.Log class comes from layoutlib-16.1.1.jar instead of android.jar, which apparently happens because I have isIncludeAndroidResources = true set for my unit tests, so this explains the difference in behaviour.

So not sure I can add test coverage for this without adding another android module to your project just for this one test. Would you be happy to just broaden the catch clause to Throwable without test coverage on this?