Move to Kotlin 1.9.23 and clean up build and source files #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faogustavo
approved these changes
Mar 12, 2024
Contributor
faogustavo
left a comment
faogustavo
left a comment
There was a problem hiding this comment.
Approved with a few comments. None of them are blockers.
Comment on lines
51
to
55
| wasmJs { | ||
| browser() | ||
| nodejs() | ||
| binaries.executable() | ||
| } |
Contributor
There was a problem hiding this comment.
I think we can simplify as in the example below. What do you think? AFAIK These configurations are only for the final output.
Suggested change
| wasmJs { | |
| browser() | |
| nodejs() | |
| binaries.executable() | |
| } | |
| wasmJs() |
Contributor
There was a problem hiding this comment.
If we can remove, also remove on JS please.
Contributor
Author
There was a problem hiding this comment.
What do you mean when you say These configurations are only for the final output. ?
Contributor
Author
There was a problem hiding this comment.
Ktor is a library and it defines the targets
https://github.com/ktorio/ktor/blob/6e52d76177a823b3c667989483e9bce35b04f53c/buildSrc/src/main/kotlin/TargetsConfig.kt#L45
findjigar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.