refactor: migrate all services to per-package structure under internal/service/#33
refactor: migrate all services to per-package structure under internal/service/#33dannysteenman merged 18 commits intomainfrom
Conversation
…reamline AWS client initialization
Extract shared CLI infrastructure (runtime, destructive actions, pointers, service group, tag parsing, test utilities) into a dedicated package for use by per-service packages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…l/service/ Move all 13 AWS service commands from the monolithic internal/cli/ package into individual packages under internal/service/<name>/. Each service package exports NewCommand() and contains its own tests and mocks. Shared runtime infrastructure (GlobalOptions, CommandRuntime, NewServiceRuntime, destructive action helpers, pointer helpers, tag parsing) was previously extracted to internal/cliutil/ and is now the sole source of these utilities. The internal/cli/ package is now slim: root command wiring, help defaults, completion, and version only. Coverage gate updated from internal/cli-only to all internal/ packages at >=80% (current: 88.1%). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0378cac0cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa7ec9c95d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa5356ebd8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| key := objectKey(object) | ||
| relativeKey := strings.TrimPrefix(key, prefix) | ||
| relativeKey = strings.TrimPrefix(relativeKey, "/") | ||
| if relativeKey == "" { | ||
| relativeKey = key |
There was a problem hiding this comment.
S3 prefixes commonly include zero-byte "folder marker" keys that end with / (for example logs/). This loop downloads every listed object without filtering those markers, so it creates a file at logs and then later fails to download real children like logs/app.log because the parent path is now a file, causing partial/failed downloads for otherwise valid buckets. Skip marker keys (or treat them as directories) before resolving targetPath and calling downloadObject.
Useful? React with 👍 / 👎.
| normalizedKey := strings.ReplaceAll(relativeKey, "\\", "/") | ||
| normalizedKey = strings.TrimPrefix(normalizedKey, "/") | ||
| normalizedKey = path.Clean(normalizedKey) |
There was a problem hiding this comment.
resolveDownloadTargetPath canonicalizes object keys with path.Clean, which collapses distinct S3 keys such as a//b.txt and a/b.txt onto the same local file path. During download-bucket, both rows can appear successful while the later object silently overwrites the earlier one, corrupting exports from buckets that contain intentionally distinct keys. Detect and fail on post-normalization path collisions instead of mapping multiple keys to one file.
Useful? React with 👍 / 👎.
|
Version tag created successfully.
Release workflow should now run for |
* refactor(rules): adopt discovery dataset dependencies * refactor(sdk): drive aws discovery from dataset registry * refactor(rules): organize discovery dataset exports * refactor(sdk): finalize discovery registry cleanup * test(sdk): assert live resource bag contents * fix(sdk): reject inherited discovery dataset keys
1 participant
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
Other information