Skip to content

feat: add AWS discovery rules for ELB, Lambda, and RDS#45

Merged
axonstone merged 5 commits intomainfrom
codex/aws-discovery-rules
Mar 24, 2026
Merged

feat: add AWS discovery rules for ELB, Lambda, and RDS#45
axonstone merged 5 commits intomainfrom
codex/aws-discovery-rules

Conversation

@axonstone
Copy link
Copy Markdown
Contributor

@axonstone axonstone commented Mar 24, 2026

Summary

  • What changed?
    • Added discovery-only AWS rules for ELB network load balancers, Lambda error rate and timeout review, and RDS reserved coverage, Graviton review, CPU utilization, unsupported engine versions, and orphaned snapshots.
    • Extended AWS discovery datasets and hydrators for Lambda metrics plus enriched RDS instance, reservation, CPU, and snapshot metadata.
    • Updated rule catalogs, metadata tests, SDK export expectations, discovery wiring tests, reference docs, and package changesets.
  • Why was this needed?
    • CloudBurn was missing these Thrifty-aligned discovery controls for several high-signal AWS cost and cleanup scenarios, so the built-in AWS discovery coverage was incomplete.

Diagram

flowchart LR
    RE["Resource Explorer catalog"] --> ELB["ELB datasets\nload balancers + target groups"]
    RE --> Lambda["Lambda datasets\nfunctions + 7d metrics"]
    RE --> RDS["RDS datasets\ninstances + reservations + CPU + snapshots"]
    ELB --> ELBRule["CLDBRN-AWS-ELB-4"]
    Lambda --> LambdaRules["CLDBRN-AWS-LAMBDA-2\nCLDBRN-AWS-LAMBDA-3"]
    RDS --> RDSRules["CLDBRN-AWS-RDS-3..7"]
Loading

Scope

  • cloudburn (cli)
  • @cloudburn/sdk
  • @cloudburn/rules
  • docs/community files

Release Notes

  • Added a .changeset/*.md file for published package changes
  • No published package changes in this PR

Verification

  • pnpm lint
  • pnpm typecheck
  • pnpm test
  • pnpm build
  • pnpm verify

Boundary Checks

  • No engine/parser/provider logic added to @cloudburn/rules
  • CLI delegates scan logic to SDK
  • README/CONTRIBUTING/docs updated when behavior changed

Open with Devin

@axonstone axonstone added the enhancement New feature or request label Mar 24, 2026
@axonstone axonstone requested a review from dannysteenman March 24, 2026 07:36
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

- scope Lambda and RDS discovery joins by account and region
- scope RDS reserved coverage by account-region seeds
- add regression tests for duplicate identifiers across accounts and regions
devin-ai-integration[bot]

This comment was marked as resolved.

- classify rds m8i and r8i families as preferred
- extend preferred-class tests for current-generation intel families
devin-ai-integration[bot]

This comment was marked as resolved.

- normalize RDS reserved engine descriptions with license suffixes
- add oracle reserved coverage regression coverage
devin-ai-integration[bot]

This comment was marked as resolved.

- hydrate RDS reserved instances once per region
- align reserved instance tests with single-account discovery
@axonstone axonstone merged commit 9413ce1 into main Mar 24, 2026
6 checks passed
@axonstone axonstone deleted the codex/aws-discovery-rules branch March 24, 2026 09:21
@github-actions github-actions bot mentioned this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant