Skip to content

feat(rules): add AWS discovery rules for edge and cost services#47

Merged
axonstone merged 1 commit intomainfrom
codex/feat-aws-discovery-rules
Mar 24, 2026
Merged

feat(rules): add AWS discovery rules for edge and cost services#47
axonstone merged 1 commit intomainfrom
codex/feat-aws-discovery-rules

Conversation

@axonstone
Copy link
Copy Markdown
Contributor

@axonstone axonstone commented Mar 24, 2026

Summary

  • What changed?
    • Added discovery-only AWS rules for API Gateway, CloudFront, Cost Explorer, DynamoDB, Route 53, and Secrets Manager.
    • Added the supporting SDK dataset loaders, AWS clients, discovery registry wiring, exports, and documentation updates.
  • Why was this needed?
    • CloudBurn needed coverage for these AWS cost and optimization checks in live discovery mode, with rule-facing datasets wired through the existing sdk -> rules discovery pipeline.

Diagram

graph TD
  A["Discovery Rules"] --> B["Discovery Dependencies"]
  B --> C["AWS Discovery Registry"]
  C --> D["Resource Explorer Seeds or Account-Scoped Loaders"]
  D --> E["SDK Hydrators"]
  E --> F["LiveResourceBag Datasets"]
  F --> G["Rule evaluateLive() Findings"]
Loading

Scope

  • cloudburn (cli)
  • @cloudburn/sdk
  • @cloudburn/rules
  • docs/community files

Release Notes

  • Added a .changeset/*.md file for published package changes
  • No published package changes in this PR

Verification

  • pnpm lint
  • pnpm typecheck
  • pnpm test
  • pnpm build
  • pnpm verify

Boundary Checks

  • No engine/parser/provider logic added to @cloudburn/rules
  • CLI delegates scan logic to SDK
  • README/CONTRIBUTING/docs updated when behavior changed

Open with Devin

@axonstone axonstone added the enhancement New feature or request label Mar 24, 2026
@axonstone axonstone requested a review from dannysteenman March 24, 2026 10:16
@axonstone
Copy link
Copy Markdown
Contributor Author

roborev: Combined Review (1c8dd0e)

Verdict: No High or Critical findings across the combined reviews.

All reviewers agreed there are no blocking issues at high severity or above.

Medium/Low findings were reported in some reviews, but omitted here per the requested threshold.


Synthesized from 4 reviews (agents: claude-code, codex | types: default, security)

@axonstone
Copy link
Copy Markdown
Contributor Author

Re: comment 4117014426

Already reviewed. This summary does not include any actionable findings, so no code change was needed.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@axonstone axonstone merged commit f44751b into main Mar 24, 2026
8 checks passed
@axonstone axonstone deleted the codex/feat-aws-discovery-rules branch March 24, 2026 10:39
@github-actions github-actions bot mentioned this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant