Make ServieFile specialized version of ServeDir#187
Merged
davidpdrsn merged 4 commits intomasterfrom Nov 24, 2021
Merged
Conversation
Nehliin
force-pushed
the
merge-serve-dir-and-file
branch
from
5cfa005 to
a964ccb
Compare
davidpdrsn
approved these changes
Nov 24, 2021
Comment on lines
+105
to
+112
| enum ServeVariant { | ||
| Directory { | ||
| append_index_html_on_directories: bool, | ||
| }, | ||
| SingleFile { | ||
| mime: HeaderValue, | ||
| }, | ||
| } |
Member
There was a problem hiding this comment.
This is a great idea! Much simpler than the design I had in mind 👍
Contributor
|
Nice! I have to give up my implementation, and I have recompiled one of my production project with the new code, it works perfectly. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes: #184 and reduces the need to implement features twice in both
ServeFileandServeDir.Solution
This implementaiton specializes
ServeDirto avoid unnecessary overhead for theServeFileusecase.ServeFilenow simply wraps aServeDirservice.