Skip to content

Extend compatibility for PyCharm Professional #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Extend compatibility for PyCharm Professional #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## [Unreleased]

- Extend compatibility for PyCharm Professional

## [2.0.0] - 2024-08-12

### Changed
Expand Down
21 changes: 13 additions & 8 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

import org.jetbrains.changelog.Changelog
import org.jetbrains.changelog.markdownToHTML
import org.jetbrains.intellij.platform.gradle.Constants.Constraints
import org.jetbrains.intellij.platform.gradle.IntelliJPlatformType
import org.jetbrains.intellij.platform.gradle.TestFrameworkType

plugins {
Expand All @@ -10,15 +10,15 @@ plugins {
alias(libs.plugins.kotlin)
alias(libs.plugins.kover)
alias(libs.plugins.ktlint)
// alias(libs.plugins.taskinfo) // cache incompatible https://gitlab.com/barfuin/gradle-taskinfo/-/issues/23
// alias(libs.plugins.taskinfo) // cache incompatible - https://gitlab.com/barfuin/gradle-taskinfo/-/issues/23
alias(libs.plugins.testLogger)
alias(libs.plugins.versionPlugin)
alias(libs.plugins.versionUpdate)
}

group = providers.gradleProperty("pluginGroup").get()
version = providers.gradleProperty("pluginVersion").get()

val platformVersion = providers.gradleProperty("platformVersion").get()
kotlin {
jvmToolchain(17)
}
Expand All @@ -36,10 +36,9 @@ dependencies {
testRuntimeOnly("junit:junit:4.13.2") // https://github.com/JetBrains/intellij-platform-gradle-plugin/issues/1711
testImplementation(libs.remoteRobot)
testImplementation(libs.remoteRobotFixtures)

intellijPlatform {
create(providers.gradleProperty("platformType"), providers.gradleProperty("platformVersion"))
plugins(providers.gradleProperty("platformPlugins").map { it.split(',') })
pycharmCommunity(platformVersion)
bundledPlugin("PythonCore")
instrumentationTools()
pluginVerifier()
zipSigner()
Expand Down Expand Up @@ -99,10 +98,16 @@ intellijPlatform {
)
}
}

pluginVerification {
ides {
recommended()
// target supporting the following platforms
ide(IntelliJPlatformType.PyCharmCommunity, platformVersion)
ide(IntelliJPlatformType.PyCharmProfessional, platformVersion)
ide(IntelliJPlatformType.IntellijIdeaCommunity, platformVersion)
ide(IntelliJPlatformType.IntellijIdeaUltimate, platformVersion)
ide(IntelliJPlatformType.GoLand, platformVersion)
ide(IntelliJPlatformType.CLion, platformVersion)
ide(IntelliJPlatformType.RustRover, platformVersion)
}
}
}
Expand Down
3 changes: 0 additions & 3 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ nl.littlerobots.vcu.resolver=true
org.gradle.caching=true
org.gradle.configuration-cache=true
org.gradle.welcome=never
# https://plugins.jetbrains.com/plugin/7322-python-community-edition/versions/stable pick compatible with IC
platformPlugins=PythonCore:241.14494.240
platformType=IC
platformVersion=2024.1
pluginGroup=com.github.pyvenvmanage
pluginName=PyVenv Manage 2
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/META-INF/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<name>PyVenv Manage 2</name>
<vendor url="https://github.com/pyvenvmanage/PyVenvManage">pyvenvmanage</vendor>

<depends>PythonCore</depends>
<depends>com.intellij.modules.python</depends>
<depends>com.intellij.modules.platform</depends>

<extensions defaultExtensionNs="com.intellij">
Expand Down