_util: drop the dead st_mtime=0 short-circuit in raise_on_not_writable_file#589
Merged
gaborbernat merged 1 commit intoJul 8, 2026
Conversation
gaborbernat
force-pushed
the
fix/mtime-zero-still-checks-writability
branch
2 times, most recently
from
79fc7f4 to
d1907b7
Compare
gaborbernat
force-pushed
the
fix/mtime-zero-still-checks-writability
branch
from
d1907b7 to
a33642f
Compare
Drop the noqa: RET506 suppression by removing the redundant else after the win32 raise, and cut comments that restate the code.
gaborbernat
force-pushed
the
fix/mtime-zero-still-checks-writability
branch
from
a33642f to
77d0652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guard predated the lstat-symlink hardening (PR #567) and was meant to defend against old platforms where os.stat could return an all-zero struct for a file that exists.