🔧 fix(type): resolve ty 0.0.25 type errors#468
Merged
gaborbernat merged 1 commit intotox-dev:mainfrom Mar 26, 2026
Merged
Conversation
Collaborator
Member
Author
|
Yeah, for now I prefer |
Collaborator
|
Fair enough! What do you prefer about its behavior? |
Member
Author
|
https://pyrefly.org/blog/container-inference-comparison/ I don't really run into this because I consider it best practice to type annotate upfront such elements. It's more unified with the ruff/uv we already use, and is just as fast as pyrefly, and I already use it in all my other projects, so makes sense to not migrate everything else too now to pyrefly. (until few days ago I trusted Astral more than FB, but alas while I still trust Astral, OpenAI I'm not that eager so that benefit is gone). |
94c05f9 to
8f7c4b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ty 0.0.25 introduced stricter type checking. This PR fixes the actual type errors and removes the temporary version pin.
Changes:
_site_data_dirs,_site_config_dirs,_site_applications_dirsas concrete properties onPlatformDirsABCsoXDGMixin.super()calls resolvectypes.WinDLLassignment withmocker.patch.objectin tests# type: ignore[misc]comments from_xdg.pyty<0.0.25version pin