Skip to content

chore: improve platformdirs maintenance path#488

Merged
gaborbernat merged 1 commit into
tox-dev:mainfrom
lphuc2250gma:maint/20260525032754
May 27, 2026
Merged

chore: improve platformdirs maintenance path#488
gaborbernat merged 1 commit into
tox-dev:mainfrom
lphuc2250gma:maint/20260525032754

Conversation

@lphuc2250gma
Copy link
Copy Markdown
Contributor

Summary:

  • Add edge-case unit tests for MacOS path resolution (e.g., site_runtime_dir/site_runtime_path, multipath=True behavior, ensure_exists=True with pre-existing dir) and tighten type annotations / add explicit return type on any helper missing it in macos.py.
  • Keep the change narrow so it is straightforward to review.

Notes:

  • I kept this scoped to the relevant implementation and tests.

Copy link
Copy Markdown
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaborbernat gaborbernat merged commit dbc63f5 into tox-dev:main May 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants