column_width is not respected everywhere

[flying-sheep]

I see this:

[tool.ruff]
...
lint.allowed-confusables = [
  "×",
  "’",
]
lint.flake8-type-checking.exempt-modules = [
]
lint.per-file-ignores."*/__init__.py" = [
  "F401",
]
lint.per-file-ignores."docs/*" = [
  "I",
]
lint.per-file-ignores."tests/*" = [
  "D",
]

and would rather see

[tool.ruff]
...
lint.allowed-confusables = [ "×", "’" ]
lint.flake8-type-checking.exempt-modules = []
lint.per-file-ignores."*/__init__.py" = [ "F401" ]
lint.per-file-ignores."docs/*" = [ "I" ]
lint.per-file-ignores."tests/*" = [ "D" ]

• allowed-confusables is like tool.hatch.envs.*.features in that it always contains a short list of strings
• lint.per-file-ignores.* too, those lists are always very short
• I think empty lists should just be on one line always, it looks super weird to expand them.

[gaborbernat]

Set https://pyproject-fmt.readthedocs.io/en/latest/#pyproject-fmt---indent accordingly.

[flying-sheep]

That option doesn’t seem in any way related to what I’m talking about, are you sure?

[gaborbernat]

The reason those go over multiple lines is that the default indent is 2 (my preferred way, makes the code diff friendly). If you increase it to like 80 will not split it across lines.

[flying-sheep]

I’m so confused, what does the indent have to do with putting things on multiple lines or not?

And why would indent = 80 ever make sense?

And why do I see this in the same file?

[tool.hatch.envs.hatch-test]
features = [ "test" ]

---

The way every formatter I’ve ever used works is (simplified)

1. check if current line is longer than max_columns
2. if yes, and last item on line is a list, split it up by only leaving [ on the current line and indenting each item by indent spaces

your docs say

# how many spaces use for indentation
indent = 2

and

--indent COUNT - number of spaces to use for indentation (default: 2)

so that seems to agree with my intuition?

where is what you say described? and why is it necessary for lint.allowed-confusables but not tool.hatch.envs.hatch-test.features?

[gaborbernat]

Sorry I meant https://pyproject-fmt.readthedocs.io/en/latest/#pyproject-fmt---column-width, also we do not roll our own formatter but defer to https://taplo.tamasfe.dev/configuration/formatter-options.html; so any bugs you might see will need to be reported there I am afraid.

[flying-sheep]

Sorry I meant pyproject-fmt.readthedocs.io/en/latest#pyproject-fmt---column-width

haha OK! now that makes more sense.

we do not roll our own formatter but defer to taplo.tamasfe.dev/configuration/formatter-options.html; so any bugs you might see will need to be reported there I am afraid.

Nope, taplo formats the example above as I want it when configured with your defaults

Can you reopen this?

[gaborbernat]

Likely some bug, PR welcome.

[flying-sheep]

The issue is (maybe among other things) helpers::array::sort which expands arrays indiscriminately.