🐛 fix(test): add i686 to known ISAs#43
Merged
gaborbernat merged 1 commit intotox-dev:mainfrom Mar 6, 2026
Merged
Conversation
The test_py_info_machine_property test fails on i686 platforms because that architecture wasn't included in the known_isas set. Fixes tox-dev#41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_py_info_machine_propertytest fails on i686 platforms because that architecture string wasn't included in theknown_isasset. Whilex86was already listed,i686is the value returned byplatform.machine()on 32-bit x86 Linux systems and is a distinct, valid identifier.Adding
i686to the set ensures the test passes on all platforms where the package is expected to work. The set entries are also sorted alphabetically for readability.Fixes #41