Skip to content

Conversation

@ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Dec 28, 2024

Fixes: #110
Depends-On: #153

@gaborbernat
Copy link
Member

I do not want to hardcode this. I want user to be able to change it, so at the very least should be configurable.

@ssbarnea
Copy link
Member Author

Doable, no problem. Still, I think that we need to alter the default to ensure the uv will prefer system instead of managed (unless configured). Otherwise, users will face broken like the bug this change is supposed to fix.

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing.

@ssbarnea
Copy link
Member Author

ssbarnea commented Jan 16, 2025

Last failure is related to iarna/iarna-toml#48 and astral-sh/setup-uv#242 - i will make a patch to stick to older versions with setup-uv for now. Now I am happy that I never used that action myself, did the install manually.

#153 is fixing the CI

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type check failure

@gaborbernat gaborbernat marked this pull request as ready for review January 16, 2025 17:31
@gaborbernat gaborbernat merged commit e123ace into tox-dev:main Jan 16, 2025
9 checks passed
@ssbarnea ssbarnea deleted the fix/sync branch June 20, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tox-uv (1.15) runs with Python 3.9, and fails with 3.10 and 3.11.

2 participants