-
-
Notifications
You must be signed in to change notification settings - Fork 33
Ensure uv pip freeze is colorless #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The 'uv pip freeze' command should automatically determine whether or not to provide coloring if the output is going to a terminal or TTY with support. This is not happening in this case. Ensuring color is always disabled for this command is a good first step to work around this issue.
|
Before: $ file .tox/py38-mindeps/constraints.txt
.tox/py38-mindeps/constraints.txt: ASCII text, with escape sequencesAfter: $ file .tox/py38-mindeps/constraints.txt
.tox/py38-mindeps/constraints.txt: ASCII text |
gaborbernat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests please.
|
Apologies, been struggling with testing this one.
|
|
Just assert against |
This test ensures we are enforcing no-color on the uv call when listing dependencies.
|
Ah ok - I was trying to write a test for the actual output from |
gaborbernat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

The 'uv pip freeze' command should automatically determine whether or not to provide coloring if the output is going to a terminal or TTY with support. This is not happening in this case.
Ensuring color is always disabled for this command is a good first step to work around this issue. Fixes #38.