Skip to content

🔒 ci(workflows): add zizmor security auditing#3896

Merged
gaborbernat merged 2 commits intotox-dev:mainfrom
gaborbernat:add-zizmor-pre-commit
Mar 25, 2026
Merged

🔒 ci(workflows): add zizmor security auditing#3896
gaborbernat merged 2 commits intotox-dev:mainfrom
gaborbernat:add-zizmor-pre-commit

Conversation

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Mar 24, 2026

GitHub Actions workflows were vulnerable to several security issues including template injection, credential exposure, and permission over-scoping. These vulnerabilities could allow attackers to execute arbitrary code or access sensitive tokens.

This change adds zizmor as a pre-commit hook to continuously audit workflow security and fixes all existing vulnerabilities. The fixes include pinning actions to commit hashes, moving secrets to dedicated environments, isolating GitHub context from shell execution, and restricting permissions to the minimum required scope.

All workflows now pass security audit with zero findings. Future workflow changes will be automatically checked before commit.

@gaborbernat gaborbernat force-pushed the add-zizmor-pre-commit branch 2 times, most recently from faae8c9 to 54d3364 Compare March 24, 2026 23:14
@gaborbernat gaborbernat changed the title Add zizmor pre-commit hook and fix security issues 🔒 ci(workflows): add zizmor security auditing Mar 24, 2026
@gaborbernat gaborbernat force-pushed the add-zizmor-pre-commit branch from 54d3364 to be9e336 Compare March 25, 2026 04:02
@gaborbernat gaborbernat force-pushed the add-zizmor-pre-commit branch from be9e336 to bfc2d6b Compare March 25, 2026 21:23
@gaborbernat gaborbernat enabled auto-merge (squash) March 25, 2026 21:26
Add zizmor pre-commit hook to catch GitHub Actions security issues.
Fix all existing findings:
- template-injection: Move GitHub context to env vars
- secrets-outside-env: Add environment declarations
- dangerous-triggers: Replace pull_request_target with pull_request
- bot-conditions: Use pull_request.user.login instead of github.actor
- excessive-permissions: Move permissions to job level
- superfluous-actions: Replace with native tools
@gaborbernat gaborbernat force-pushed the add-zizmor-pre-commit branch from 97ea07b to 4520ae2 Compare March 25, 2026 21:53
@gaborbernat gaborbernat merged commit 16df4d8 into tox-dev:main Mar 25, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants