Skip to content

feat: Also pass TERMINFO when in an interactive shell#3946

Merged
gaborbernat merged 2 commits into
tox-dev:mainfrom
edgarrmondragon:feat/TERMINFO
May 27, 2026
Merged

feat: Also pass TERMINFO when in an interactive shell#3946
gaborbernat merged 2 commits into
tox-dev:mainfrom
edgarrmondragon:feat/TERMINFO

Conversation

@edgarrmondragon
Copy link
Copy Markdown
Contributor

@edgarrmondragon edgarrmondragon commented May 19, 2026

Ghostty uses TERMINFO, instead of installing into the terminfo database, to advertise terminal capabilities. The Ghostty docs instructs users to configure tools (e.g. ssh) which sanitize their environment variables to preserve this variable.

Without this change, I'm seeing

$ tox -e 3.14
3.14: uv-sync> /Users/work/.local/share/uv/tools/tox/bin/uv sync --locked --python-preference system --no-default-groups --group tests -p cpython3.14
3.14: commands[0]> coverage run -m pytest tests
No entry for terminal type "xterm-ghostty";
using dumb terminal settings.
================ test session starts ================
platform darwin -- Python 3.14.5, pytest-9.0.3, pluggy-1.6.0

Ghostty docs: https://ghostty.org/docs/help/terminfo

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
Comment thread tests/conftest.py
Copy link
Copy Markdown
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaborbernat gaborbernat merged commit 4e6627c into tox-dev:main May 27, 2026
27 checks passed
@edgarrmondragon edgarrmondragon deleted the feat/TERMINFO branch May 27, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants