feat: set frontend and backend url from env var#58
Merged
Conversation
|
✔️ Deploy Preview for python-playground ready! 🔨 Explore the source changes: 18f63a4 🔍 Inspect the deploy log: https://app.netlify.com/sites/python-playground/deploys/60c8c0590431170007eb4694 😎 Browse the preview: https://deploy-preview-58--python-playground.netlify.app/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set frontend and backend url from environment variable
This could allow the forks of this repo to have their own playground + playground URLs.
Additional context
Usage:
Set
PG_BACKEND_SITE_NAMEandPG_BACKEND_SITE_NAME_PRin Netlify UI for backend site name, not url.Those environment variables are used to make backend API URL.
Set
PG_FRONTEND_SITE_NAME(this is site name) andCUSTOM_DOMAIN_URL(optional, this is url) in heroku for frontend.There is no env var for pull request since netlify generates a deploy preview url by default. So, only the site name is needed.
There is also an optional
CUSTOM_DOMAIN_URLenv var which can be used to set custom domain url. When setting this environment variable, if you are not sure the correct url form, you can uselocation.originto get the correct url name for connecting frontend and backend.What is the purpose of this pull request?