Introduce a Unitful extension #126
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was perusing documentation for Turing and DynamicHMC recently, and realized that in quite a lot of my code I have been implementing my own transforms, in the fragile way where things are hard-coded everywhere. I think I could stand to clean up and standardize a lot of that code just by having transforms like in this package.
Rather than attempt to broaden the number types of e.g.
ShiftedExp
to admit Unitful quantities, this PR adds a dimensionalDimShiftedExp
, which takes advantage of the type signatures of Unitful quantities to encode the destination units in the type itself.Some things that this PR makes possible:
Two things this PR doesn't currently try to do:
I'm open to discussion on any of these details--just thought that I would throw together a working draft and see if there would be interest in allowing these kinds of transformations.