Made client properties thread safe. #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you, I will review this one and get back to you. A you have pointed out, this is a breaking change. I have a breaking release planned, but it will take some time before i push it (when you are making breaking changes you really want for them to be the right one). |
tpeczek
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tomasz,
I realised that if the client properties collection is thread safe it can then be more useful in more usage scenarios. This PR removes the Properties dictionary and replaces it with a set of 3 methods (SetProperty, GetProperty and RemoveProperty) backed up by a ConcurrentDictionary.
The ConcurrentDictionary can now store objects rather then just strings, again to increase its usefulness in more usage scenarios. Therefore, the before mentioned methods are implemented as generics to enforce type checking.
Unfortunately this is a breaking change.
Best regards,
Sebastiano