X11 skipped on neovim tui

[SevereOverfl0w]

Due to neovim/neovim#3626

Workaround: Look at $WINDOWID as well

[SevereOverfl0w]

gnome-terminal is broken in this regard for vim8 also, see https://gitlab.gnome.org/GNOME/gnome-terminal/issues/17

[tpope]

$WINDOWID can be stale, in a re-attached tmux for instance, while v:windowid is verified to be valid by Vim, at least at startup. I'm not sure I want to dig my heals in any deeper on an already sketchy adapter.

I think :terminal support will probably render this adapter largely moot?

[SevereOverfl0w]

I'm using this to run lein, which I want to be persistent when restarting vim because it's so very slow to start.

[tpope]

I think the correct solution is to ignore v:windowid and just grab the currently active window id. That's really what we want to focus anyways. If Vim for some reason kicked off a :Start while not being focused, we would want to keep the current window focused, not switch to Vim.

It doesn't look like wmctrl can get the current window id? What a bizarre feature set. I know that xdotool can, or we can parse it out of xprop -root _NET_ACTIVE_WINDOW. Can you investigate an implementation?

[SevereOverfl0w]

I'll take a look tomorrow or Saturday. I think you're right, there's alternatives that are perfectly appropriate for this environment.

The only downside of doing this is that if someone is using a fancy terminal that tracks window ids against tabs, then it won't focus back afterwards.

[SevereOverfl0w]

Quick first-pass:

diff --git a/autoload/dispatch/x11.vim b/autoload/dispatch/x11.vim
index 74f3129..86be76a 100644
--- a/autoload/dispatch/x11.vim
+++ b/autoload/dispatch/x11.vim
@@ -5,12 +5,29 @@ if exists('g:autoloaded_dispatch_x11')
 endif
 let g:autoloaded_dispatch_x11 = 1
 
+function! s:windowid_available()
+  return v:windowid || executable('xprop') || executable('xdotool') || executable('pfw')
+endf
+
+function! s:windowid()
+
+  if v:windowid
+    return v:windowid
+  elseif executable('xprop')
+    return substitute(system("xprop -root '\t$0' _NET_ACTIVE_WINDOW"), '.*\t', '', '')
+  elseif executable('xdotool')
+    return system('xdotool getactivewindow')
+  elseif executable('pfw')
+    return system('xdotool getactivewindow')
+  endif
+endf
+
 function! dispatch#x11#handle(request) abort
   if $DISPLAY !~# '^:'
     return 0
   endif
   if get(a:request, 'background') &&
-        \ (!v:windowid || !executable('wmctrl'))
+        \ (s:windowid_available() == 0 || !executable('wmctrl'))
     return 0
   endif
   if exists('g:dispatch_terminal_exec')
@@ -32,7 +49,8 @@ endfunction
 function! dispatch#x11#spawn(terminal, command, request) abort
   let command = dispatch#set_title(a:request) . '; ' . a:command
   if a:request.background
-    let command = 'wmctrl -i -a '.v:windowid . ';' . command
+    let command = 'wmctrl -i -a '.s:windowid() . ';' . command
+    echom command
   endif
   call system(a:terminal . ' ' . dispatch#shellescape(&shell, &shellcmdflag, command). ' &')
   return 1

[tpope]

I believe xprop is standard, shouldn't need fallbacks.