Add xprop fallback for windowid #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpope
requested changes
Jul 12, 2019
SevereOverfl0w
force-pushed
the
x11-xprop
branch
2 times, most recently
from
53dc7fd to
d4ca76c
Compare
Contributor
Author
|
I've pushed up with changes requested. I've also passed through the windowid because it felt strange that we might potentially get |
Owner
|
Yes, passing through the windowid is appropriate, it also prevents an extra |
Some popular terminals, e.g. gnome-terminal do not set $WINDOWID. Additionally, the Neovim TUI does not yet support $WINDOWID. Fix tpope#277
SevereOverfl0w
force-pushed
the
x11-xprop
branch
from
d4ca76c to
207e94f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some popular terminals, e.g. gnome-terminal do not set $WINDOWID.
Additionally, the Neovim TUI does not yet support $WINDOWID.
Fix #277