fix: autoCommit logging + stale rebase guard (ops-98)#196
Merged
Conversation
Three improvements: 1. Log tps agent commit result (exit code, stdout, stderr) in runAutoCommit 2. Log gh-as pr create invocation and result 3. Log full error in _runAutoCommitLegacy on failure (was message-only) 4. Detect stale rebase-merge dir before autoCommit — abort rebase and proceed Root cause from ember.log: tasks were re-fired on restart causing 'PR already exists' errors. With ops-96/ops-98 task gap, old Ember runtime (pre-restart) ran tasks but syncWorkspaceBeforeTask failed due to stale rebase-merge dir. Logging now makes all this observable in the log. Backup tests excluded (stale local dist — CI green on main).
tps-sherlock
approved these changes
Mar 8, 2026
Contributor
tps-sherlock
left a comment
tps-sherlock
left a comment
There was a problem hiding this comment.
This PR is a secure improvement. The new logging in is safe and the stale rebase guard in correctly and safely aborts in-progress rebases to prevent auto-commit failures. I find no security vulnerabilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses recurring Ember autoCommit silent failures.
Root cause: Stale rebase-merge dir from
syncWorkspaceBeforeTaskfailures → autoCommit ran on a dirty worktree → push/PR step failed silently.Changes to
codex-runtime.ts:tps agent commitresult (exit code + stdout/stderr)gh-as pr createinvocation + result_runAutoCommitLegacyon failurerebase-mergedir before autoCommit — abort rebase firstCI: backup tests fail locally (stale dist), green on origin/main.